[Pidgin] #7516: XMPP "headline" messages create new conversation tab in 2.5.2

Pidgin trac at pidgin.im
Tue Jan 6 14:03:23 EST 2009


#7516: XMPP "headline" messages create new conversation tab in 2.5.2
-------------------+--------------------------------------------------------
 Reporter:  jts    |        Owner:  deryni
     Type:  patch  |       Status:  new   
Milestone:         |    Component:  XMPP  
  Version:  2.5.2  |   Resolution:        
 Keywords:         |  
-------------------+--------------------------------------------------------

Comment(by jts):

 Hm - My reading comprehension needs some improvement, as I just realized
 this is exactly what darkrain42 suggested yesterday :). I'm not sure what
 "other ticket" refers to in the context of JABBER_MESSAGE_OTHER, so unless
 that's something important please consider this the proposed patch.
 Hopefully it'll make it into 2.5.3. Thanks.
 {{{
 --- message_2_5_2.c    2008-11-11 15:26:51.000000000 -0500
 +++ message.c   2008-11-11 15:26:10.107798000 -0500
 @@ -616,7 +616,7 @@
                                                 }

                                                 jabber_id_free(jid);
 -                                       } else {
 +                                       } else if (jm->type ==
 JABBER_MESSAGE_NORMAL || jm->type == JABBER_MESSAGE_CHAT) {
                                                 conv =
 purple_find_conversation_with_account(PURPLE_CONV_TYPE_ANY,
                                                                 who,
 account);
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7516#comment:10>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list