[Pidgin] #7761: Fixes for libpurple to avoid segfaults

Pidgin trac at pidgin.im
Thu Jan 8 18:00:04 EST 2009


#7761: Fixes for libpurple to avoid segfaults
--------------------+-------------------------------------------------------
 Reporter:  vadiml  |        Owner:  datallah 
     Type:  patch   |       Status:  new      
Milestone:  2.5.4   |    Component:  libpurple
  Version:  2.5.2   |   Resolution:           
 Keywords:          |  
--------------------+-------------------------------------------------------

Comment(by darkrain42):

 I've discovered another corner case :)

 I'm currently testing with this trivial patch applied:
 {{{
 --- pidgin/gtkmain.c    2668e844ffc992c38cdf4bfc848fb870cd56328c
 +++ pidgin/gtkmain.c    1aa8d872b5008f674537a111099cbf68a34e0586
 @@ -322,9 +322,6 @@ pidgin_quit(void)
         pidgin_session_end();
  #endif

 -       /* Save the plugins we have loaded for next time. */
 -       pidgin_plugins_save();
 -
         /* Uninit */
         pidgin_smileys_uninit();
         pidgin_conversations_uninit();
 }}}

 If I quit while a prefs save is scheduled (I fiddle with the list of
 loaded plugins and immediately quit), the `prefs.xml` is saved to the
 wrong place, overwriting my main pidgin instances' prefs.xml (Pidgin was
 run as `pidgin -c .purple-test -d`):
 {{{
 (14:55:20) util: Writing file status.xml to directory .purple-test/
 (14:55:20) util: Writing file .purple-test//status.xml
 snip plugins being unloaded...
 (14:55:20) util: Writing file prefs.xml to directory /home/paul/.purple
 (14:55:20) util: Writing file /home/paul/.purple/prefs.xml
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7761#comment:19>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list