[Pidgin] #7761: Fixes for libpurple to avoid segfaults

Pidgin trac at pidgin.im
Thu Jan 8 18:15:20 EST 2009


#7761: Fixes for libpurple to avoid segfaults
--------------------+-------------------------------------------------------
 Reporter:  vadiml  |        Owner:  datallah 
     Type:  patch   |       Status:  new      
Milestone:  2.5.4   |    Component:  libpurple
  Version:  2.5.2   |   Resolution:           
 Keywords:          |  
--------------------+-------------------------------------------------------

Comment(by darkrain42):

 Sorry, datallah, I shouldn't have suggested putting the
 `purple_prefs_uninit()` below everything else wrt crashing the gtkdebug
 window; the prefs uninit must be called before util_uninit.

 I audited all the uninit functions after this in `purple_core_quit()`;
 none of them call any prefs code or rely on prefs (and the UI is shut
 down, so it won't die on gtkdebug)

 {{{
 --- libpurple/core.c    4b25950b0f744009084a69c33a2707720965efc0
 +++ libpurple/core.c    a02e8836d5600e7092beb27fc0c616581ca4d177
 @@ -227,6 +227,7 @@ purple_core_quit(void)
         if (ops != NULL && ops->quit != NULL)
                 ops->quit();

 +       purple_prefs_uninit();
         purple_plugins_uninit();
  #ifdef HAVE_DBUS
         purple_dbus_uninit();
 @@ -243,7 +244,6 @@ purple_core_quit(void)
  #ifdef _WIN32
         wpurple_cleanup();
  #endif
 -       purple_prefs_uninit();

         _core = NULL;
  }
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7761#comment:20>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list