[Pidgin] #9603: Pidgin no longer gives password retry prompt

[Pidgin]

#9603: Pidgin no longer gives password retry prompt
------------------------------------------------+---------------------------
 Reporter:  eus                                 |        Owner:  sulabh.dev
     Type:  defect                              |       Status:  new       
Milestone:                                      |    Component:  Yahoo!    
  Version:  2.5.8                               |   Resolution:            
 Keywords:  Pidgin Yahoo Password Retry Prompt  |  
------------------------------------------------+---------------------------

Comment(by sulabh.dev):

 Replying to [comment:3 MarkDoliner]:
 > Looks like the new Yahoo authentication code is sending "Received
 invalid data" as the connection error message instead of "Incorrect
 Password."  I think libpurple might look for
 PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED when deciding whether to
 prompt for a new password.
 [[BR]]
 This shouldn't be happening, here is the portion of code associated with
 setting error for incorrect password:[[BR]]
 {{{
 case 1212:
         /* Password incorrect */
         error_reason = g_strdup(_("Incorrect Password"));
         error = PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED;
         break;
 .
 .
 .
 purple_connection_error_reason(gc, error, error_reason);
 }}}
 [[BR]]
 There has been some recent change in the i.p.p. which sets the response to
 invalid data, which is NOT the case with Pidgin 2.5.8. In 2.5.8, as eus
 said, account is disabled and incorrect password displayed.[[BR]]
 I will look into what was that recent change. Also do we need to set
 password to NULL from prpl, in case of wrong password, or is sending error
 reason PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED enough.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9603#comment:6>
Pidgin <http://pidgin.im>
Pidgin