[Pidgin] #9603: Pidgin no longer gives password retry prompt

[Pidgin]

#9603: Pidgin no longer gives password retry prompt
------------------------------------------------+---------------------------
 Reporter:  eus                                 |        Owner:  sulabh.dev
     Type:  defect                              |       Status:  new       
Milestone:                                      |    Component:  Yahoo!    
  Version:  2.5.8                               |   Resolution:            
 Keywords:  Pidgin Yahoo Password Retry Prompt  |  
------------------------------------------------+---------------------------

Comment(by sulabh.dev):

 Replying to [comment:3 MarkDoliner]:
 > Looks like the new Yahoo authentication code is sending "Received
 invalid data" as the connection error message instead of "Incorrect
 Password."

 This is issue with i.p.p. only, not with Pidgin 2.5.8[[BR]]
 Fixed:
 http://developer.pidgin.im/viewmtn/revision/info/89e296ce85f6724fd51ae1efdc5883941cdf90ca

 > I think libpurple might look for
 PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED when deciding whether to
 prompt for a new password.

 libpurple doesn't decide to prompt for a new password, prpls when receive
 incorrect password modify password to NULL, which causes that prompt to
 appear. But this is done only if accounts have save password option
 unchecked. Why don't we do so for the accounts that save passwords? I
 think we should. Also we should handle this in libpurple rather than
 letting prpls decide.

 Fixes #9603:
 http://d.pidgin.im/viewmtn/revision/info/b05f93669b412dc123c17699c1c394cb2f30673d

-- 
Ticket URL: <http://developer.pidgin.im/ticket/9603#comment:7>
Pidgin <http://pidgin.im>
Pidgin