[Pidgin] #8911: Pidgin tries to close nonexistent tabs when closing conversation windows

[Pidgin]

#8911: Pidgin tries to close nonexistent tabs when closing conversation windows
---------------------+------------------------------------------------------
 Reporter:  kriston  |        Owner:              
     Type:  defect   |       Status:  new         
Milestone:           |    Component:  pidgin (gtk)
  Version:  2.5.8    |   Resolution:              
 Keywords:           |  
---------------------+------------------------------------------------------

Comment(by darkrain42):

 {{{
 cat pidgin-crash.txt
 (11:16:11) Gtk: gtk_widget_show: assertion `GTK_IS_WIDGET (widget)' failed

 Program received signal SIGSEGV, Segmentation fault.
 0x0809e39e in pidgin_conv_window_add_gtkconv (win=0x821ee50,
 gtkconv=0x8497040) at gtkconv.c:9361
 9361            gtk_widget_grab_focus(focus_gtkconv->entry);

 }}}

 kriston is currently trying this patch:
 {{{
 --- pidgin/gtkconv.c    a9e0961e6eb6b74741242d23db1fd773166264c6
 +++ pidgin/gtkconv.c    67fbb1426b52897e7a345a74aa1f63e36e86788b
 @@ -9474,7 +9474,9 @@ pidgin_conv_window_add_gtkconv(PidginWin

         gtk_widget_show(tab_cont);

 -       if (pidgin_conv_window_get_gtkconv_count(win) == 1) {
 +       purple_debug_info("gtkconv", "gtkconv count is %d\n",
 +                       pidgin_conv_window_get_gtkconv_count(win));
 +       if (pidgin_conv_window_get_gtkconv_count(win) <= 1) {
                 /* Er, bug in notebooks? Switch to the page manually. */
                 gtk_notebook_set_current_page(GTK_NOTEBOOK(win->notebook),
 0);
         } else {
 @@ -9483,7 +9485,8 @@ pidgin_conv_window_add_gtkconv(PidginWin

         focus_gtkconv =
 g_list_nth_data(pidgin_conv_window_get_gtkconvs(win),
 gtk_notebook_get_current_page(GTK_NOTEBOOK(win->notebook)));
 -       gtk_widget_grab_focus(focus_gtkconv->entry);
 +       if (focus_gtkconv)
 +               gtk_widget_grab_focus(focus_gtkconv->entry);

         if (pidgin_conv_window_get_gtkconv_count(win) == 1)
                 update_send_to_selection(win);

 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8911#comment:3>
Pidgin <http://pidgin.im>
Pidgin