[Pidgin] #7340: Bad programming practice

Pidgin trac at pidgin.im
Thu Jul 16 20:43:48 EDT 2009


#7340: Bad programming practice
-----------------------------------------+----------------------------------
 Reporter:  fsilveira                    |        Owner:           
     Type:  patch                        |       Status:  new      
Milestone:  Patches Needing Improvement  |    Component:  libpurple
  Version:  2.5.2                        |   Resolution:           
 Keywords:                               |  
-----------------------------------------+----------------------------------
Changes (by QuLogic):

  * milestone:  Patches Needing Review => Patches Needing Improvement


Comment:

 The reason why there is no `do { } while(0)` around this macro is that it
 contains `continue`'s. Adding the loop would not result in the same code.

 Maybe you can come up with something better, but you'll have to be careful
 as it appears the ordering is important in a few places.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7340#comment:9>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list