[Pidgin] #7340: Bad programming practice

Pidgin trac at pidgin.im
Sun Jul 19 02:41:56 EDT 2009


#7340: Bad programming practice
-----------------------------------------+----------------------------------
 Reporter:  fsilveira                    |        Owner:           
     Type:  patch                        |       Status:  new      
Milestone:  Patches Needing Improvement  |    Component:  libpurple
  Version:  2.5.2                        |   Resolution:           
 Keywords:                               |  
-----------------------------------------+----------------------------------

Comment(by darkrain42):

 At the very least, we probably should put braces around the if() statement
 in the long set of ALLOW_TAG()s a few lines further done, I think.

 I'm just not comfortable enough with that function to know whether or not
 the lack of braces (and thus one chunk of the macro always executing) is
 intentional.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7340#comment:10>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list