[Pidgin] #8813: Disabling an IRC account doesn't disconnect it (was: Disabling an IRC chat doesn't disconnect it)

[Pidgin]

#8813: Disabling an IRC account doesn't disconnect it
--------------------+-------------------------------------------------------
 Reporter:  zacw    |           Owner:  elb
     Type:  defect  |          Status:  new
Milestone:          |       Component:  IRC
  Version:  2.5.5   |      Resolution:     
 Keywords:          |   Launchpad_bug:     
--------------------+-------------------------------------------------------

Old description:

> When disabling an IRC chat, through a command such as:
> {{{
> purple_account_set_enabled(account, "Adium", NO);
> }}}
> The account does not disconnect itself, unlike all other protocols.
> Immediately issuing a
> {{{
> purple_account_disconnect(account);
> }}}
> will cause the account to properly disconnect. My best-guess is that
> gc->wants_to_die is set to TRUE, so it early-returns away from the
> disconnect later on in the {{{purple_account_set_enabled}}}.

New description:

 When disabling an IRC account, through a command such as:
 {{{
 purple_account_set_enabled(account, "Adium", NO);
 }}}
 The account does not disconnect itself, unlike all other protocols.
 Immediately issuing a
 {{{
 purple_account_disconnect(account);
 }}}
 will cause the account to properly disconnect. My best-guess is that
 gc->wants_to_die is set to TRUE, so it early-returns away from the
 disconnect later on in the {{{purple_account_set_enabled}}}.

--

Comment(by zacw):

 And, to further pollute the timeline, didn't notice I had editing
 permission on the ticket; too used to Adium's trac. Fixing.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8813#comment:2>
Pidgin <http://pidgin.im>
Pidgin