[Pidgin] #8813: Disabling an IRC account doesn't disconnect it

[Pidgin]

#8813: Disabling an IRC account doesn't disconnect it
--------------------+-------------------------------------------------------
 Reporter:  zacw    |           Owner:  elb
     Type:  defect  |          Status:  new
Milestone:          |       Component:  IRC
  Version:  2.5.5   |      Resolution:     
 Keywords:          |   Launchpad_bug:     
--------------------+-------------------------------------------------------

Old description:

> When disabling an IRC account, through a command such as:
> {{{
> purple_account_set_enabled(account, "Adium", NO);
> }}}
> The account does not disconnect itself, unlike all other protocols.
> Immediately issuing a
> {{{
> purple_account_disconnect(account);
> }}}
> will cause the account to properly disconnect. My best-guess is that
> gc->wants_to_die is set to TRUE, so it early-returns away from the
> disconnect later on in the {{{purple_account_set_enabled}}}.

New description:

 When disabling an IRC account, through a command such as:
 {{{
 purple_account_set_enabled(account, "Adium", NO);
 }}}
 The account does not disconnect itself, unlike all other protocols.
 Issuing a
 {{{
 purple_account_disconnect(account);
 }}}
 will cause the account to error:
 {{{
 ** (process:17738): CRITICAL **: purple_account_disconnect: assertion
 `!purple_account_is_disconnected(account)' failed
 }}}
 Since the state doesn't appear to be set at all for its connection.

--

Comment(by zacw):

 After playing around a bit more, the latter is intrue: disconnecting is
 impossible.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/8813#comment:3>
Pidgin <http://pidgin.im>
Pidgin