[Pidgin] #10503: Pidgin Crash when receiving email from various endpoints

[Pidgin]

#10503: Pidgin Crash when receiving email from various endpoints
-------------------+--------------------------------------------------------
Reporter:  CNLohr  |        Type:  patch           
  Status:  new     |   Component:  pidgin (gtk)    
 Version:  2.6.2   |    Keywords:  email icon crash
-------------------+--------------------------------------------------------
 I commonly receive various problems (glibc errors, segfault, etc.) when
 using some plugins that send email to pidgin that are not directly
 associated with accounts.

 I tracked the problem down:

 pidgin_create_prpl_icon()

 Makes a call to: g_return_val_if_fail(...)

 This causes debug builds to function properly, however for release builds,
 where G_DISABLE_CHECKS is set, Pidgin crashes every now and then.

 The reason for this is g_return_val_if_fail(...) is not functioning at
 all.

 I propose adding a:

         if( account == NULL )
                 return NULL;

 in the function beforehand, so the function does not continue running
 without an account.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10503>
Pidgin <http://pidgin.im>
Pidgin