[Pidgin] #10623: --disable-missing-dependencies turns on features even when the needed libs are missing

[Pidgin]

#10623: --disable-missing-dependencies turns on features even when the needed libs
are missing
--------------------------+-------------------------------------------------
 Reporter:  nix_nix       |     Owner:  rekkanoryo
     Type:  defect        |    Status:  new       
Component:  unclassified  |   Version:  2.6.3     
 Keywords:                |  
--------------------------+-------------------------------------------------
 {{{
         if test "x$enable_startup_notification" = "xyes"; then
                 PKG_CHECK_MODULES(STARTUP_NOTIFICATION, [libstartup-
 notification-1.0 >= 0.5], , [                        AC_MSG_RESULT(no)
 enable_startup_notification=no ###### THIS IS NEEDED ######
                         if test "x$force_deps" = "xyes" ; then
                                 AC_MSG_ERROR([
 Startup notification development headers not found.
 Use --disable-startup-notification if you do not need it.
 ])
                         fi])

                 if test "x$enable_startup_notification" = "xyes"; then
                         AC_DEFINE(HAVE_STARTUP_NOTIFICATION, 1, [Define if
 we're using libstartup-notification.])
                         AC_SUBST(STARTUP_NOTIFICATION_CFLAGS)
                         AC_SUBST(STARTUP_NOTIFICATION_LIBS)
                 fi
         fi
 }}}

 The line pointed out above is needed for all checks that have the above
 structure, otherwise the AC_DEFINE and AC_SUBST lines will happen even if
 the PKG_CHECK_MODULES fails.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10623>
Pidgin <http://pidgin.im>
Pidgin