[Pidgin] #10304: < in AIM and ICQ statuses breaks the entire tooltip

[Pidgin]

#10304: < in AIM and ICQ statuses breaks the entire tooltip
---------------------------+------------------------------------------------
 Reporter:  NightWolf1298  |        Owner:  MarkDoliner
     Type:  defect         |       Status:  new        
Milestone:                 |    Component:  AIM        
  Version:  2.6.2          |   Resolution:             
 Keywords:                 |  
---------------------------+------------------------------------------------

Comment(by sadrul):

 oscar.c:oscar_user_info_append_status reads:
 {{{
         /* Away messges are HTML, but available messages were originally
 plain text.
          * We therefore need to strip away messages but not available
 messages if we're asked to remove HTML tags.
 }}}

 However, we do strip the status messages even for available status in
 oscar.c:oscar_status_text. And, stripping the available message in
 oscar_user_info_append_status does seem to fix this issue. Patch
 (http://pidgin.im/~sadrul/pp/fix_10304.diff):
 {{{
 ============================================================
 --- libpurple/protocols/oscar/oscar.c
 30e87e6ef00929edd5d21dba83a159533e278e1f
 +++ libpurple/protocols/oscar/oscar.c
 1dd5af53779bf3122519b86c74a029e24a43f391
 @@ -861,7 +861,7 @@ static void oscar_user_info_append_statu
                 /* Away messges are HTML, but available messages were
 originally plain text.
                  * We therefore need to strip away messages but not
 available messages if we're asked to remove HTML tags.
                  */
 -               if (is_away && message) {
 +               if (message) {
                         gchar *tmp2;
                         tmp = purple_markup_strip_html(message);
                         g_free(message);
 @@ -880,7 +880,7 @@ static void oscar_user_info_append_statu
         }
         g_free(itmsurl);

 -       if (is_away && message) {
 +       if (message) {
                 tmp = purple_str_sub_away_formatters(message,
 purple_account_get_username(account));
                 g_free(message);
                 message = tmp;
 }}}

 A second look from someone else at the patch would be good.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10304#comment:1>
Pidgin <http://pidgin.im>
Pidgin