[Pidgin] #10891: gevolution plugin adds buddies to random account

[Pidgin]

#10891: gevolution plugin adds buddies to random account
------------------------------------+---------------------------------------
 Reporter:  cedel                   |        Owner:         
     Type:  patch                   |       Status:  new    
Milestone:  Patches Needing Review  |    Component:  plugins
  Version:  2.6.3                   |   Resolution:         
 Keywords:  gevolution Evolution    |  
------------------------------------+---------------------------------------

Comment(by QuLogic):

 What is `changewin->selection` for? It does not appear to be used outside
 of the function in which it is set, so why does it need to be saved?

 Using `g_list_length` to check if the list is 0, 1, or "many" is not
 necessary. Just check `list` and `list->next`. Also, you call
 `g_list_length` multiple times instead of using the cached value in `d`.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/10891#comment:11>
Pidgin <http://pidgin.im>
Pidgin