[Pidgin] #11595: libpurple - MSN crashes when sending file

[Pidgin]

#11595: libpurple - MSN crashes when sending file
--------------------+-------------------------------------------------------
 Reporter:  hanzz   |        Owner:  QuLogic
     Type:  defect  |       Status:  new    
Milestone:          |    Component:  MSN    
  Version:  2.6.6   |   Resolution:         
 Keywords:          |  
--------------------+-------------------------------------------------------

Comment(by hanzz):

 Ok, I'm adding my latest patch which fixes this ticket for me. I've also
 tested it in Pidgin.

 {{{
 #
 # old_revision [5596fda5b3d5323e89b01f2a273b71eb74156b46]
 #
 # patch "libpurple/protocols/msn/slp.c"
 #  from [8347895b2576ff2044f0fe63e29f0e464084bf83]
 #    to [f3e5e3c028a283ececff9999f536ce3d8123fa62]
 #
 # patch "libpurple/protocols/msn/slplink.c"
 #  from [d4aefb42cb2a3334a2dda05c1e016848f7484141]
 #    to [e5dd01fbe9a57fe0bd4264e97f23b1dfe3a43191]
 #
 ============================================================
 --- libpurple/protocols/msn/slp.c
 8347895b2576ff2044f0fe63e29f0e464084bf83
 +++ libpurple/protocols/msn/slp.c
 f3e5e3c028a283ececff9999f536ce3d8123fa62
 @@ -154,6 +154,7 @@ msn_xfer_write(const guchar *data, gsize
         slpcall->u.outgoing.len = len;
         slpcall->u.outgoing.data = data;
         msn_slplink_send_msgpart(slpcall->slplink, slpcall->xfer_msg);
 +       msn_message_unref(slpcall->xfer_msg->msg);
         return MIN(1202, len);
  }

 ============================================================
 --- libpurple/protocols/msn/slplink.c
 d4aefb42cb2a3334a2dda05c1e016848f7484141
 +++ libpurple/protocols/msn/slplink.c
 e5dd01fbe9a57fe0bd4264e97f23b1dfe3a43191
 @@ -314,6 +314,7 @@ msg_ack(MsnMessage *msg, void *data)
                 if (slpmsg->slpcall->xfer &&
 purple_xfer_get_status(slpmsg->slpcall->xfer) ==
 PURPLE_XFER_STATUS_STARTED)
                 {
                         slpmsg->slpcall->xfer_msg = slpmsg;
 +                       msn_message_ref(msg);
                         purple_xfer_prpl_ready(slpmsg->slpcall->xfer);
                 }
                 else
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/11595#comment:7>
Pidgin <http://pidgin.im>
Pidgin