[Pidgin] #4792: "Status to apply at startup" is not used for default statuses

[Pidgin]

#4792: "Status to apply at startup" is not used for default statuses
--------------------+-------------------------------------------------------
 Reporter:  ari     |        Owner:  darkrain42  
     Type:  defect  |       Status:  new         
Milestone:          |    Component:  pidgin (gtk)
  Version:  2.3.1   |   Resolution:              
 Keywords:          |  
--------------------+-------------------------------------------------------

Comment(by Ryan Dwyer):

 I've found the cause of the problem, but I've never developed in desktop
 software so I might leave it for a Pidgin dev to fix. I registered here
 just to post this.

 Firstly, some information about the preference values:

 In prefs.xml, startup_current_status relates to the tickbox "Use status
 from last exit at startup". If 1, it will use the previous status and
 ignore what is selected in the combo box. If 0, it uses the combo box
 value.

 The "startup" value is the selected status. It's a timestamp which relates
 to the status in status.xml.

 When I experienced this bug just now the value of my "startup" was 0 so
 the timestamp didn't match anything in status.xml. After changing it to
 something else (in my case Invisible) and back to Available it's now got a
 timestamp value and I've confirmed it's working correctly.

 I think the fix should be done in libpurple/savedstatuses.c, function
 purple_savedstatus_get_startup(). The function loads the timestamp and if
 it matches a valid status, returns it. If it doesn't match any status it
 returns the "current" (aka last used) status. I think it should just
 return the Available status if there's no match.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4792#comment:12>
Pidgin <http://pidgin.im>
Pidgin