[Pidgin] #13270: SASL support on IRC Protocol

[Pidgin]

#13270: SASL support on IRC Protocol
------------------------------------+---------------------------------------
 Reporter:  Gaming4JC               |        Owner:  elb
     Type:  patch                   |       Status:  new
Milestone:  Patches Needing Review  |    Component:  IRC
  Version:  2.7.9                   |   Resolution:     
 Keywords:                          |  
------------------------------------+---------------------------------------

Comment(by nenolod):

 Replying to [comment:4 andy753421]:
 > I got hit by the same issue on freenode using a tethering plan (T-Mobile
 oddly enough though). Anyway, I wrote a patch for sasl authentication and
 attached it, it works for me using pidgin 2.7.11 (patch is against 2.9.0
 though).
 >
 > Note: freenode doesn't prefix the AUTHENTICATE message with
 :whatever.freenode.net so the message fails to parse. There's a lame work-
 around in irc_msg_cap; it seems that you can send `AUTHENTICATE PLAIN' and
 `AUTHENTICATE <password data>' both at the same time without waiting
 for a reply from the first message.

 Yes, this will work, but you should wait for the challenge because other
 mechanisms like DH-BLOWFISH are bidirectionally interactive.

 The IRC parser should be more relaxed.  Messages from the server are not
 explicitly required to have an origin.

 There are some comments in the patch which are related to IRCv3 capability
 negotiation that are incorrectly attributed to being related to SASL.
 Those should probably be changed.

 >
 > I'm not really a pidgin developer so feel free to fix or point out any
 coding conventions that I violated. Also, if one of the devs wants to
 suggest a proper way to fix the above mentioned lame workaround, feel free
 to do so and I'll fix that as well.

 The solution regarding the workaround is to refactor the IRC parser to
 accept messages without origin prefix, as such messages are valid.  In the
 event of no specified origin, the origin is assumed to be the hostname of
 the server the socket is connected to, either user-specified or server-
 provided (from 001 numeric).

 >
 > Per TipsForPatchSubmissions, if you want to put some log files:
 >  - Name:  Andy Spencer
 >  - Email: andy753421 at gmail.com

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13270#comment:6>
Pidgin <http://pidgin.im>
Pidgin