[Pidgin] #14641: MSN contact through federation from Office Communicator does not show up

[Pidgin]

#14641: MSN contact through federation from Office Communicator does not show up
--------------------------------------------------------+-------------------
 Reporter:  fis                                         |     Owner:  QuLogic
     Type:  defect                                      |    Status:  new    
Component:  MSN                                         |   Version:  2.10.0 
 Keywords:  2.10.0 MSN federated OCS LCS lync contacts  |  
--------------------------------------------------------+-------------------
 I have a contact on my MSN contact list using Microsoft Office
 Communicator's MSN federation at their end. The contact only appears in
 the official clients (Live Messenger, live.com web interface), but does
 not show up in any libpurple-based clients I've tried (Pidgin 2.10.0,
 Pidgin 2.7.11, ...). At least superficially the problem resembles that of
 #6755.

 Attached is a snippet of sanitized purple-debug.log showing the federated
 contact and a normal contact in the address book SOAP reply.

 The problem seems to be that the contact list parser looks for the
 <passportName> element first; having found that, it checks the
 <isMessengerUser> element, and since that contains "false", the contact is
 skipped. Federated users seem to be handled in the branch when
 <passportName> does not exist, in which case the information is properly
 picked up from the <emails> element, assuming it has <isMessengerEnabled>
 set to true.

 Attached is also a crude patch (against 2.10.0, looks like it'd apply to
 the mtn head too) which changes the above logic to look for the <emails>
 element first, and process the contact as a federated one if it exists. It
 appears to work for me, though I have not tested it extensively. Feel free
 to use it or ignore it as you see fit; I can't be absolutely sure it
 doesn't break anything else, given that I don't have any Yahoo-federated
 contacts or anything.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/14641>
Pidgin <http://pidgin.im>
Pidgin