[Pidgin] #15090: freenode's new +q numeric (728) is unrecognized
Pidgin
trac at pidgin.im
Sat May 5 10:56:19 EDT 2012
#15090: freenode's new +q numeric (728) is unrecognized
---------------------+------------------------------------------------------
Reporter: marienz | Owner: elb
Type: defect | Status: new
Milestone: | Component: IRC
Version: 2.10.3 | Resolution:
Keywords: |
---------------------+------------------------------------------------------
Comment(by marienz):
The second patch has a typo that makes it not compile
(PURPLE_MESSAGE_STYSTEM should be PURPLE_MESSAGE_SYSTEM) and a mistake
that makes it not work: args[0] needs to be split into 5 pieces, not 4, as
the last piece includes the entire remainder of the string. So
positions[3] ends up being "##marienz q $~a
marienz!marienz at freenode/staff/marienz 1335995600" which will never match
an active conversation. It works with both occurrences of 4 changed to 5.
Printing positions[4] instead of args[0] will then conveniently print a
shorter message (see reasoning in the previous comment).
--
Ticket URL: <http://developer.pidgin.im/ticket/15090#comment:6>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list