[Pidgin] #15090: freenode's new +q numeric (728) is unrecognized

Pidgin trac at pidgin.im
Sat May 5 13:16:44 EDT 2012


#15090: freenode's new +q numeric (728) is unrecognized
---------------------+------------------------------------------------------
 Reporter:  marienz  |        Owner:  elb
     Type:  defect   |       Status:  new
Milestone:           |    Component:  IRC
  Version:  2.10.3   |   Resolution:     
 Keywords:           |  
---------------------+------------------------------------------------------

Comment(by elb):

 EionRobb: You're right, it gets rid of the GOTO, but it also does a bunch
 of unnecessary allocation.  I'm not convinced one of those poor behaviors
 is particularly superior to the other.  ;-)  But then again, GOTO doesn't
 really offend me...  The numeric check is also lossy there.

 marienz: You are absolutely correct, regarding the NULL check.  The point
 about trimming the leading info is also good.  However, we should probably
 keep the numeric itself.  I'll make those changes.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/15090#comment:7>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list