[Pidgin] #7469: Don't unnecessarily convert XMPP avatars to PNG

[Pidgin]

#7469: Don't unnecessarily convert XMPP avatars to PNG
-----------------------------+------------------------
 Reporter:  edam             |       Owner:
     Type:  enhancement      |      Status:  new
Milestone:                   |   Component:  libpurple
  Version:  2.5.2            |  Resolution:
 Keywords:  avatar png xmpp  |
-----------------------------+------------------------

Comment (by edam):

 Regarding only doing the conversion when it wouldn't break size
 guidelines, can you be sure of what size limits the server will impose?
 The original bug report came after I was using jabberd2, which just
 truncates the image data to 8KB!  What's worse is that it then sends the
 truncated (corrupted) image to the clients, as if it were a valid image!
 Tsck...

 There is another reason not to do the conversion.  This behaviour also
 breaks animated GIFs (for which only the first frame is uploaded to the
 server).

 Where we've set an animated GIF on the server, pidgin has been able to
 download it and display it OK.  It is only animated in the chat window and
 the get-user-info window.  The buddy list and buddy list pop-up info
 tooltip show only the first frame.  But what this shows is that pidgin is
 able to download and use a GIF.  It clearly isn't converting it here, or
 it wouldn't be animated.  So wouldn't this also imply that the conversion
 to a PNG is not required (for pidgin's purposes, I mean)?

-- 
Ticket URL: <https://developer.pidgin.im/ticket/7469#comment:2>
Pidgin <http://pidgin.im>
Pidgin