[Pidgin] #13270: SASL support on IRC Protocol

[Pidgin]

#13270: SASL support on IRC Protocol
------------------------------------+------------------
 Reporter:  Gaming4JC               |       Owner:  elb
     Type:  patch                   |      Status:  new
Milestone:  Patches Needing Review  |   Component:  IRC
  Version:  2.7.9                   |  Resolution:
 Keywords:                          |
------------------------------------+------------------

Comment (by teleshoes):

 Replying to [comment:15 elb]:
 > The patch is not "written well", and it's been discussed in the XMPP
 chat.  It is still a hack.  I'll put the details here for the benefit of
 those who missed it.

 in terms of understandability and clarity, this code is reasonable => it
 is unlikely to introduce weird regressions.

 >  * This patch hand-implements SASL PLAIN, which is a bad idea for both
 security and flexibility reasons.  Other protocols use Cyrus SASL, as this
 should.
 >  * The strncmp() check is wrong (it should use len 5).
 >  * There is no indication to the client that the authentication
 succeeded or failed.

 yes, code review and a few tweaks would be nice. this is not a permanent
 soln, but as an interim until someone gets around to properly implementing
 cyrus sasl, it should do fine and not break everything. folks would get
 the critical functionality they need, and the real fix could come later.

-- 
Ticket URL: <https://developer.pidgin.im/ticket/13270#comment:18>
Pidgin <http://pidgin.im>
Pidgin