[Pidgin] #15750: IRC ACTIONs skip sending-im-msg signal.
Pidgin
trac at pidgin.im
Tue Sep 10 13:32:27 EDT 2013
#15750: IRC ACTIONs skip sending-im-msg signal.
--------------------+-------------------------
Reporter: xnyhps | Owner: elb
Type: patch | Status: new
Milestone: | Component: IRC
Version: 2.10.7 | Keywords: irc otr /me
--------------------+-------------------------
For most protocols {{{/me}}} gets sent raw, but is displayed differently.
For IRC, it is also sent differently. Because {{{/me}}} is interpreted as
a command, it bypasses all normal message logic, including the "sending-
im-msg" signal. This implies that, for instance, OTR does not get a chance
to encrypt the message and it is sent in plain.
Because this is undesirable when using OTR, the "sending-im-msg" signal
should fire. Attached patch implements this.
Note that it encrypts "\001ACTION " part too, to be compatible with other
IRC clients with OTR support. I'm not sure this is desirable for all
plugins that look for the "sending-im-msg" signal.
--
Ticket URL: <https://developer.pidgin.im/ticket/15750>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list