[Pidgin] #16323: Fingerprint based SSL certificate approval

Pidgin trac at pidgin.im
Wed Aug 20 15:55:38 EDT 2014

#16323: Fingerprint based SSL certificate approval
 Reporter:  cyisfor                         |       Owner:
     Type:  enhancement                     |      Status:  new
Milestone:  Patches Needing Improvement     |   Component:  libpurple
  Version:  2.10.9                          |  Resolution:
 Keywords:  security server authentication  |
Changes (by QuLogic):

 * keywords:  ssl, certificate, fingerprint, security, server,
     authentication => security server authentication
 * milestone:   => Patches Needing Improvement


 I can't say much about the intent of this patch, but as to its contents:
  * If your functions are not used elsewhere, make them `static`. There's
 no need for the extra prototypes. If they are used elsewhere, the
 prototypes need to go in the headers, of course.
  * Can `g_build_filename` ever fail? Asserting on the result seems pretty
 drastic, and probably unnecessary.
  * You've used spaces instead of tabs for indent.
  * Please add spaces after commas.
  * I'm not sure if we can use GIO on Windows. Someone will have to clarify
 that point (maybe we've updated requirements so it's okay.)
  * A status of `G_IO_STATUS_ERROR` will trigger the `continue` and you'll
 probably stuck in an infinite loop.
  * What's up with the odd condition on line 186? I think you should just
 re-use the `status` variable there.
  * ''derp'' is not a useful debug category.
  * (Some parts of) GByteArray may be too new for us.

Ticket URL: <https://developer.pidgin.im/ticket/16323#comment:2>
Pidgin <https://pidgin.im>

More information about the Tracker mailing list