[Pidgin] #15625: IRC plugin uses incorrect port for SSL

[Pidgin]

#15625: IRC plugin uses incorrect port for SSL
-------------------------+------------------
 Reporter:  andy753421   |       Owner:  elb
     Type:  enhancement  |      Status:  new
Milestone:               |   Component:  IRC
  Version:  2.10.7       |  Resolution:
 Keywords:  irc ssl tls  |
-------------------------+------------------

Comment (by belmyst):

 From my reading of {{{irc.c}}}, it's easy to change the default SSL port
 to 6697, but since on account creation the preference {{{port}}}
 {{{
 option = purple_account_option_int_new(_("Port"), "port",
 IRC_DEFAULT_PORT);
         prpl_info.protocol_options =
 g_list_append(prpl_info.protocol_options, option);
 }}}
 is set to the default port (6667),
 {{{
         purple_connection_update_progress(gc, _("Connecting"), 1, 2);

         if (purple_account_get_bool(account, "ssl", FALSE)) {
                 if (purple_ssl_is_supported()) {
                         irc->gsc = purple_ssl_connect(account,
 irc->server,
                                         purple_account_get_int(account,
 "port", IRC_DEFAULT_SSL_PORT),
                                         irc_login_cb_ssl,
 irc_ssl_connect_failure, gc);
 }}}
 will fail to use the correct port.

 I believe this could be fixed by:
 * not setting a default port in
 {{{
 option = purple_account_option_int_new(_("Port"), "port",
 IRC_DEFAULT_PORT);
         prpl_info.protocol_options =
 g_list_append(prpl_info.protocol_options, option);
 }}}
   which should let the code above use the default ports.
 * perhaps adding STARTTLS to IRC. But this requires both client and server
 support.

--
Ticket URL: <https://developer.pidgin.im/ticket/15625#comment:1>
Pidgin <https://pidgin.im>
Pidgin