[Pidgin] #16233: Custom emoticons don't show in XMPP under certain conditions

[Pidgin]

#16233: Custom emoticons don't show in XMPP under certain conditions
-----------------------------------+---------------------
 Reporter:  jvisc                  |       Owner:  deryni
     Type:  defect                 |      Status:  new
Milestone:                         |   Component:  XMPP
  Version:  2.10.9                 |  Resolution:
 Keywords:  emoticons,xmpp,pidgin  |
-----------------------------------+---------------------

Comment (by jvisc):

 The issue is the following logic found in
 libpurple/protocols/jabber/message.c

 {{{
 chat = jabber_chat_find_by_conv(PURPLE_CHAT_CONVERSATION(conv));
 if (chat) {
         /* do not attempt to send custom smileys in a MUC with more than
          10 people, to avoid getting too many BoB requests */
         return jabber_chat_get_num_participants(chat) <= 10 &&
                 jabber_chat_all_participants_have_capability(chat,
                         NS_BOB);

 } else {
         return FALSE;
 }
 }}}

 The logic seems flawed - why should a single user joining a chatroom
 disable emoticons for everyone else? Their client should simply ignore the
 emoticon content and not ask for BOB data.

 Limiting it to the number of users in a chatroom seems somewhat more
 logical, but that should be noted somewhere!!!

 The fix is simple:

 {{{
 chat = jabber_chat_find_by_conv(PURPLE_CHAT_CONVERSATION(conv));
 if (chat) {
         return TRUE; /* Always send emoticon content, even if clients
 don't support it */
 } else {
         return FALSE;
 }
 }}}

--
Ticket URL: <https://developer.pidgin.im/ticket/16233#comment:2>
Pidgin <https://pidgin.im>
Pidgin