[Pidgin] #16752: File descriptor leak in Pidgin + GStreamer 1.x

[Pidgin]

#16752: File descriptor leak in Pidgin + GStreamer 1.x
-----------------------+---------------------------
 Reporter:  XRevan86   |       Owner:
     Type:  patch      |      Status:  closed
Milestone:  2.10.12    |   Component:  pidgin (gtk)
  Version:  3.0.0hg    |  Resolution:  fixed
 Keywords:  gstreamer  |
-----------------------+---------------------------

Comment (by dx):

 >eventually a segmentation fault

 May I ask what the segmentation fault looked like?

 Is it something like this?

 {{{
 #0  0x00007f0e72819b24 in g_source_attach (source=source at entry=0x0,
 context=0x0) at /build/glib2.0-ajuDY6/glib2.0-2.46.1/./glib/gmain.c:1163
 #1  0x00007f0e74b848b8 in gst_bus_add_watch_full_unlocked (bus=<optimized
 out>, priority=<optimized out>, func=0x56004c7ceeb0 <bus_call>,
 user_data=0x56004e00aa40, notify=0x0) at gstbus.c:885
 #2  0x00007f0e74b849e0 in gst_bus_add_watch_full (bus=0x7f0e14009260
 [GstBus], priority=0, func=0x56004c7ceeb0 <bus_call>,
 user_data=0x56004e00aa40, notify=0x0) at gstbus.c:936
 #3  0x000056004c7cfb3a in pidgin_sound_play_file (filename=<optimized
 out>)
     at /build/pidgin-hiYwOJ/pidgin-2.10.11/./pidgin/gtksound.c:543
 #4  0x000056004c7cf927 in pidgin_sound_play_event
 (event=PURPLE_SOUND_SEND)
     at /build/pidgin-hiYwOJ/pidgin-2.10.11/./pidgin/gtksound.c:616
 }}}

 Asking because ubuntu applied a version of the gstreamer 1.0 patch that
 doesn't have this fix, and they are getting the above.

 {{{source}}} is null because {{{bus->priv->poll}}} is null, which we
 believe is because {{{gst_poll_new()}}} failed, which we strongly suspect
 it's because of this. Confirming would be nice.

--
Ticket URL: <https://developer.pidgin.im/ticket/16752#comment:11>
Pidgin <https://pidgin.im>
Pidgin