[Pidgin] #16708: Use of deprecated GNOME Keyring secure memory

[Pidgin]

#16708: Use of deprecated GNOME Keyring secure memory
---------------------+--------------------------
 Reporter:  mmcco    |      Owner:  EionRobb
     Type:  defect   |     Status:  new
Milestone:  3.0.0    |  Component:  unclassified
  Version:  3.0.0hg  |   Keywords:
---------------------+--------------------------
 When compiling the GNOME Keyring plugin, you see these warnings:

 {{{
 Making all in keyrings
 make[5]: Entering directory '/home/mike/mmcc-
 pidgin/libpurple/plugins/keyrings'
   CC       internalkeyring_la-internalkeyring.lo
   CC       gnomekeyring_la-gnomekeyring.lo
 gnomekeyring.c: In function 'gnomekeyring_request_free':
 gnomekeyring.c:76:3: warning: 'gnome_keyring_memory_free' is deprecated
 (declared at /usr/include/gnome-keyring-1/gnome-keyring-memory.h:70): Use
 'gcr_secure_memory_free' instead [-Wdeprecated-declarations]
    gnome_keyring_memory_free(req->password);
    ^
 gnomekeyring.c: In function 'gnomekeyring_process_queue':
 gnomekeyring.c:306:3: warning: 'gnome_keyring_find_password' is deprecated
 (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:490): Use
 'secret_password_lookup' instead [-Wdeprecated-declarations]
    current_request = gnome_keyring_find_password(
    ^
 gnomekeyring.c:318:3: warning: 'gnome_keyring_store_password' is
 deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:473):
 Use 'secret_password_store' instead [-Wdeprecated-declarations]
    current_request = gnome_keyring_store_password(
    ^
 gnomekeyring.c:329:3: warning: 'gnome_keyring_delete_password' is
 deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:502):
 Use 'secret_password_clear' instead [-Wdeprecated-declarations]
    current_request = gnome_keyring_delete_password(
    ^
 gnomekeyring.c: In function 'gnomekeyring_save':
 gnomekeyring.c:368:2: warning: 'gnome_keyring_memory_strdup' is deprecated
 (declared at /usr/include/gnome-keyring-1/gnome-keyring-memory.h:76): Use
 'gcr_secure_memory_strdup' instead [-Wdeprecated-declarations]
   req->password = gnome_keyring_memory_strdup(password);
   ^
 gnomekeyring.c: In function 'gnomekeyring_cancel':
 gnomekeyring.c:380:3: warning: 'gnome_keyring_cancel_request' is
 deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:183)
 [-Wdeprecated-declarations]
    gnome_keyring_cancel_request(current_request);
    ^
 gnomekeyring.c: In function 'plugin_load':
 gnomekeyring.c:427:2: warning: 'gnome_keyring_is_available' is deprecated
 (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:169)
 [-Wdeprecated-declarations]
   if (!gnome_keyring_is_available()) {
   ^
   CCLD     gnomekeyring.la
   CCLD     internalkeyring.la
 make[5]: Leaving directory '/home/mike/mmcc-
 pidgin/libpurple/plugins/keyrings'
 }}}

 GNOME Keyring's non-pageable memory was deprecated in favor of libsecret:

 https://mail.gnome.org/archives/commits-list/2014-January/msg01585.html

 The changes look pretty trivial. I should be able to fix them in the next
 day or two in my repo. I thought I'd open a ticket so that I don't forget,
 and to make sure it eventually gets committed.

--
Ticket URL: <https://developer.pidgin.im/ticket/16708>
Pidgin <https://pidgin.im>
Pidgin