[Pidgin] #16724: recent change breaks conversation re-joining

[Pidgin]

#16724: recent change breaks conversation re-joining
---------------------+--------------------------
 Reporter:  cyisfor  |      Owner:
     Type:  defect   |     Status:  new
Milestone:  2.10.12  |  Component:  libpurple
  Version:  2.10.11  |   Keywords:  conversation
---------------------+--------------------------
 Back in June, change 37200:50884c0b222a prevented creating a new
 conversation when an old one was already found. This is a bad idea of
 course, since purple_conversation_new /already/ checks if an old
 conversation exists, and does important rejoining logic when it does.

 So, when your connection is disconnected, all involved conversations have
 their names surrounded in "()" and the enter key or submit is disabled in
 them (since the connection is lost, and it doesn't queue them locally).

 Before this patch, once pidgin reconnects to the network it removes the
 "()" and enables you to submit again. After this patch, it does not remove
 the "()" and submit is permanently disabled. If you close the tab, and try
 to select "join" from the buddy list, it fails silently. Only quitting and
 restarting the entire process will allow you to rejoin the conversation,
 and actually type messages into it. Until the next network failure, in
 which your submitting is permanently disabled again. (The chat messages
 continue to display in the window just fine.)

 What needs to happen, I think, is just rolling back these patches and
 naively calling purple_conversation_new, and perhaps renaming it to
 purple_conversation_assure or purple_conversation_check to avoid future
 misunderstanding.

--
Ticket URL: <https://developer.pidgin.im/ticket/16724>
Pidgin <https://pidgin.im>
Pidgin