[Pidgin] #16001: Duplicate calls to purple_xfer_set_bytes_sent()

Pidgin trac at pidgin.im
Mon Jun 22 19:09:08 EDT 2015

#16001: Duplicate calls to purple_xfer_set_bytes_sent()
 Reporter:  MarkDoliner  |       Owner:  tomkiewicz
     Type:  defect       |      Status:  new
Milestone:  3.0.0        |   Component:  libpurple
  Version:  3.0.0hg      |  Resolution:
 Keywords:               |

Comment (by mmcco):

 Simply removing the call to `purple_xfer_set_bytes_sent()` in
 `do_transfer()` causes received files to be truncated non-

 Now that I'm looking deeper into the code, I think that
 `purple_xfer_set_bytes_sent()` should actually be used to refer to how
 much data is ''successfully received and written'', not how much comes
 over the wire, because it is used to determine when the transfer has

 Here, we again choose between the easy road and the more correct one. We

 * change the name to something that sounds less networky
 * make a new pair of attributes and helper functions to deal with the
 amount of actual successfully transferred and written data
 * leave it as it is and tweak as necessary

 I'm starting with option 3.  :)

Ticket URL: <https://developer.pidgin.im/ticket/16001#comment:4>
Pidgin <https://pidgin.im>

More information about the Tracker mailing list