[Pidgin] #16001: Duplicate calls to purple_xfer_set_bytes_sent()

Pidgin trac at pidgin.im
Mon Jun 22 18:27:01 EDT 2015

#16001: Duplicate calls to purple_xfer_set_bytes_sent()
 Reporter:  MarkDoliner  |       Owner:  tomkiewicz
     Type:  defect       |      Status:  new
Milestone:  3.0.0        |   Component:  libpurple
  Version:  3.0.0hg      |  Resolution:
 Keywords:               |

Comment (by mmcco):

 `do_transfer()` is only called in `libpurple/xfer.c` by UI-related

 `purple_xfer_read_file()` and `purple_xfer_write_file()` are called
 directly by some protocols, namely: Mxit, Yahoo, Sametime, and Gadu-Gadu.

 It seems that `do_transfer()`, regardless of what it was intended to be,
 is in practice an abstraction used internally by libpurple's rather than
 part of the API. No protocol uses it directly. Jabber and MSN use it
 through `purple_xfer_protocol_ready()`.

 It would take some refactoring and testing of old protocols to be able to
 do traffic accounting in `do_transfer()`. It seems like removing
 accounting from `do_transfer()` is a lot less invasive, but it's probably
 something we'd want to consider in the long-term.

 I'm testing this now.

Ticket URL: <https://developer.pidgin.im/ticket/16001#comment:3>
Pidgin <https://pidgin.im>

More information about the Tracker mailing list