pidgin: 8d15933c: xmlCleanupParser() should not be called ...

nosnilmot at pidgin.im nosnilmot at pidgin.im
Wed Jan 13 09:08:20 EST 2010


-----------------------------------------------------------------
Revision: 8d15933cb1afbdb96ed8bcb9f072b800771d9e4a
Ancestor: f59b76bb4cbb167f2bb020900e8ceceb0d8c83a8
Author: nosnilmot at pidgin.im
Date: 2010-01-13T14:00:29
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/8d15933cb1afbdb96ed8bcb9f072b800771d9e4a

Modified files:
        finch/libgnt/gntutils.c

ChangeLog: 

xmlCleanupParser() should not be called like it was being
http://0pointer.de/blog/projects/beware-of-xmlCleanupParser.html
http://git.gnome.org/browse/libxml2/tree/parser.c#n14002

I just removed calls to it, as I suspect it probably shouldn't
be called from a library like libgnt anyway.

-------------- next part --------------
============================================================
--- finch/libgnt/gntutils.c	1e82c66ec9e26d6fa1b9d8bc5b045226895f7fa9
+++ finch/libgnt/gntutils.c	ebdd83522f2e3760dda578913b95387ad9f3427e
@@ -373,7 +373,6 @@ void gnt_util_parse_widgets(const char *
 
 	xmlFreeDoc(doc);
 	xmlFreeParserCtxt(ctxt);
-	xmlCleanupParser();
 	va_end(list);
 	g_free(data);
 #endif
@@ -470,7 +469,6 @@ gboolean gnt_util_parse_xhtml_to_textvie
 		ret = TRUE;
 	}
 	xmlFreeParserCtxt(ctxt);
-	xmlCleanupParser();
 	return ret;
 #endif
 }


More information about the Commits mailing list