Revision e7a9b68352bd0cf9de6b52c20667d528b5d5e7bc

[Mark Doliner]

On Thu, 07 Jun 2007 05:39:52 -0400, Stu Tomlinson wrote
> On Thu, 2007-06-07 at 02:27 -0400, markdoliner at pidgin.im wrote:
> > Modified files:
> >         libpurple/protocols/msn/servconn.c
> > 
> > ChangeLog: 
> > 
> > We should surface this error to the user when calling
> > purple_connection_error(), but I don't feel like mucking with this
> > code right now, and this is better than nothing
> 
> Mark,
> 
> I think it is already surfaced to the user in cases where the user
> should care about it. See what msn_servconn_got_error() actually 
> does.

msn_servconn_got_error() prints a message... but it's not as detailed as it
could be.

> Was there a specific problem that was not being reported that 
> you thinnk should be?

For example, if the initial connect to the notification server fails the error
message currently says, "Connection error from Notification server: Unable to
connect"

But it could say, "Error connecting to notification server: Access denied:
HTTP proxy server forbids port 1863 tunneling", which is more useful.

Other good things to do would be to automatically try using the HTTP method. 
Or mention to the user that they should edit their MSN account and enable
"HTTP method."  Or maybe have a link to our wiki that explains the error
message about forbidding port 1863 tunneling.

-Mark