Patches for pidgin-2.2.0 on RHEL4

[John Bailey]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Zvi Har'El wrote:
> Dear Sean,
> 
> 
> pidig-2.2.0 has a couple of new programs in the plugins directory,
> namely, helloworld.c and noify_example.c. However, these programs do not
> include the header file internal.h, which defines the symbol 
> G_GNUC_NULL_TERMINATED, a definition which is needed for older versions
> of glib (as mine - I am using RHEL4, which has glib2-2.4.7-1). Thus,
> they fail to compile, and the whole build fails.
> 
> Also, I found out that an include for I attach a trivial patch, which
> adds the necessary include lines.

Those plugins should not be including internal.h, by my judgement.  I wrote them
specifically for demonstrative purposes, where people would be using them as a
guide for writing third-party plugins.  The idea is to keep the plugins
distributed in the tarballs as close as possible to what I have on our wiki
pages.  I have since committed a fix for such older glib installations that does
not include internal.h.

> Another patch needed was due to a change of the file pidgin/pidgin.h,
> which made the inclusion of gdk/gdkx.h conditionally on
> 
> #ifdef GDK_WINDOWING_X11 instead of #ifndef _WIN32. Since nothing seemed
> to define the former symbol in my configuration, the compilation of
> pidgin/gtkutils.c, which needs that gdk header file, failed. I attach
> another patch which fixed the problem.

As I recall, this specifically was needed to support compiling with native GTK+
on Mac OS X, where the point is to _not_ require X11.  Reverting to an #ifndef
_WIN32 breaks this goal.

> Finally , some linux distributions (like mine, RHEL4),  doesn't have a
> x11.pc file, and starting at pidgin-2.2.0, it is used to check for X
> support. I attach the file I created for that and put in
> /usr/local/lib/pkgconfig, but I suppose it is better to have a fallback
> cheking method, like the one used in pidgin-2.1.1 configuration.

There have already been fixes committed to alleviate this problem.  They will be
present in Pidgin 2.2.1.

John
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFG7rrtBWJH/emdNtsRAqsKAKDOz9oNw8qDODj/GURPtYMPz5sVkgCaAjvr
ipcuvE6XEH5Yq5VSVgtu1+k=
=4UEp
-----END PGP SIGNATURE-----