[PATCH] Non-ASCII alias is totally stripped

马旋(SuperMMX) supermmx at gmail.com
Mon Aug 31 02:47:16 EDT 2009

Hash: SHA1

Hi, guys:

I am regular MTN trunk user of Pidgin, and sometimes contribute to Pidgin.
But this time, this bug removes all my aliases in Chinese.

The bug was introduced in revision c61d5559bb5cfd55defb3613015e9118dbc2184e
which changed the logic of purple_utf8_strip_unprintables. It was not
aware of Non-ASCII characters at all.

The patch is simple and attached.

This makes me think of what Pidgin need in development : Code Review,
which can void many stupid bugs like this one. 

- -- 
A. Because it makes the logic of the discussion difficult to follow.
Q. Why shoudn't I top post?
A. No.
Q Should I top post?

A: Because it destroys the flow of the conversation
Q: Why is it bad?
A: No, it's bad.
Q: Should I top post in replies to mailing lists? 
Version: GnuPG v1.4.8 (MingW32)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: chinese_alias.diff
Type: text/x-patch
Size: 707 bytes
Desc: not available
URL: <http://pidgin.im/pipermail/devel/attachments/20090831/2881145f/attachment-0002.bin>

More information about the Devel mailing list