pidgin: d1328041: disapproval of revision '8e7b47f18e014b8...

[Kevin Stange]

On 10/04/2011 08:58 AM, Andrew Victor wrote:
> hi,
> 
>> I talked to Kevin in the XMPP muc and his reason was basically that he
>> doesn't know what the intended purpose is for PURPLE_CONV_TYPE_MISC
>> and he's betting Andrew doesn't know either (I also don't know), and
>> Kevin thinks we should try to assess whether it's useful before
>> getting rid of it.
>>
>> That sounded reasonable to me.  So, uh, anyone know if
>> PURPLE_CONV_TYPE_MISC serves a purpose?
> 
> I did first search on code.google.com for references to
> PURPLE_CONV_TYPE_MISC.
> 
> Only real references I could find were:
> 1.http://pidgin-woodpecker.googlecode.com/svn-history/r67/trunk/extras/src/roombrowse.c
> A plugin where the web-page mentions it "no longer works".
> 
> 2. Adium
> Where PURPLE_CONV_TYPE_MISC is treated the same as
> PURPLE_CONV_TYPE_UNKNOWN.

It sounds like you did your homework.  I apologize for assuming
otherwise.  Does anyone know what this was supposed to do or any reason
people might want it to be restored to operation versus deleted?

Also, as Eion asked, do we want to just eliminate this while
consolidating PurpleConversation types?

>> - Some Pidgin devs think it's useful for committers to be available in
>> IRC or the XMPP multi-user chat while making commits, in case someone
>> has questions about them.
> 
> I do hang-out in the XMPP MUC occasionally (nickname = Pavlov).

I can't remember having ever seen you talk, but it's good to know you're
there.  I'll have to remember to poke you from time to time with comments.

Kevin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://pidgin.im/pipermail/devel/attachments/20111004/1b4ccd14/attachment.sig>