/pidgin/main: e6c37a5e6666: New dependency: libcurl
eion at robbmob.com
Fri Sep 28 21:09:29 EDT 2012
I don't thing that purple functions should be specific to curl or lib soup,
that it'd be best to wrap it (like we have done for farsight2/far stream
and for nss and that other one) so that they can be swapped out as needed.
I would be more in favour of making the current request functions work
with optionally either lib soup or curl, specified at compile time.
On Saturday, 29 September 2012, Tomasz Wasilczyk wrote:
> I have just written draft of curl wrapper implementation . It's
> tied into purple event loop and allows using curl_easy interface. It
> needs some more features to write (response headers handling, stopping
> requests, maybe some more), but it works pretty well. It's still a
> draft, so it needs some code polishing.
> > On Fri, Sep 28, 2012 at 4:31 AM, Tomasz Wasilczyk
> >>>> New dependency: libcurl
> > When did we decide to use libcurl over libsoup?
> >>> Adding libcurl, do we want to rework our HTTP utility functions to
> >>> simply wrap libcurl? They could automatically become more robust, but
> >>> am curious whether we care.
> >> I think so. But at first, I plan to write curl-specific wrapper:
> >> functions like purple_curl_* to initialize curl handler (tie into
> >> purple event loop), watch it and so on.
> > If we're still going to have our HTTP functions, then I don't see why
> > this needs to exist (publically). That's just an artificial API
> > dependency.
> Actually, I think we could only maintain these purple_curl_* functions
> and set our internal ones as deprecated: curl used with my brand new
> wrapper  is pretty easy to use, so we can rewrite current code just
> to use it. I think, we should export it to the public API, to allow
> plugins using this new feature.
> Example usage is shown in libpurple/protocols/gg/gg.c (see patch).
> Waiting for comments,
>  http://pastebin.com/ra3pQD6L
> Devel mailing list
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Devel